Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community distribution fixes #292

Merged
merged 11 commits into from
Dec 3, 2019

Conversation

ramereth
Copy link
Contributor

@ramereth ramereth commented Sep 8, 2019

Description

This provides some fixes which will allow community distributions the ability to easily override various URLs. In addition, this separates out the PRODUCT_MATRIX into it's own file which community distributions could also override as needed.

NOTE: omnitruck will likely need to be updated to pull in the product matrix properly. I will be providing a PR for that soon. I do not believe dependent gems will run into this issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@ramereth ramereth requested review from a team as code owners September 8, 2019 00:20
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
This makes it much easier for other community projects to use mixlib-install and
set their our product matrix.

Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
This updates the installation scripts so that the default product can be
configurable via a distro constant called DEFAULT_PRODUCT. It currently defaults
to "chef".

Signed-off-by: Lance Albertson <lance@osuosl.org>
…ants

Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
The default installation directory on MacOS includes "chef_software" which
should be configurable for distributions of Chef.

Signed-off-by: Lance Albertson <lance@osuosl.org>
The default installation directory on Windows includes "opscode" which should be
configurable for distributions of Chef.

Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth ramereth force-pushed the community-distribution-fixes branch from cda4266 to 7ce47e5 Compare October 7, 2019 22:06
Copy link

@miah miah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ramereth

lib/mixlib/install/dist.rb Outdated Show resolved Hide resolved
lib/mixlib/install/dist.rb Outdated Show resolved Hide resolved
lib/mixlib/install/dist.rb Outdated Show resolved Hide resolved
Signed-off-by: Lance Albertson <lance@osuosl.org>
@tas50 tas50 merged commit 5470228 into chef:master Dec 3, 2019
ramereth added a commit to ramereth/omnitruck that referenced this pull request Dec 15, 2019
This applies some fixes which were introduced in [1] that help support community
distributions better.

[1] chef/mixlib-install#292

Signed-off-by: Lance Albertson <lance@osuosl.org>
ramereth added a commit to ramereth/omnitruck that referenced this pull request Dec 15, 2019
This applies some fixes which were introduced in [1] that help support community
distributions better.

[1] chef/mixlib-install#292

Signed-off-by: Lance Albertson <lance@osuosl.org>
ramereth added a commit to ramereth/omnitruck that referenced this pull request Dec 15, 2019
This applies some fixes which were introduced in [1] that help support community
distributions better. Some other fixes include:

- Ensure we pull in mixlib-install >= 3.11.23 which includes the patches
  introduced in [1]
- Create dist.rb file for renaming chef to something else and also set the SLES
  project versions to other names

[1] chef/mixlib-install#292

Signed-off-by: Lance Albertson <lance@osuosl.org>
ramereth added a commit to ramereth/omnitruck that referenced this pull request Mar 12, 2020
This applies some fixes which were introduced in [1] that help support community
distributions better.

[1] chef/mixlib-install#292

Signed-off-by: Lance Albertson <lance@osuosl.org>
ramereth added a commit to ramereth/omnitruck that referenced this pull request Mar 14, 2020
This applies some fixes which were introduced in [1] that help support community
distributions better. Some other fixes include:

- Ensure we pull in mixlib-install >= 3.11.23 which includes the patches
  introduced in [1]
- Create dist.rb file for renaming chef to something else and also set the SLES
  project versions to other names

[1] chef/mixlib-install#292

Signed-off-by: Lance Albertson <lance@osuosl.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants