-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community distribution fixes #292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
This makes it much easier for other community projects to use mixlib-install and set their our product matrix. Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
This updates the installation scripts so that the default product can be configurable via a distro constant called DEFAULT_PRODUCT. It currently defaults to "chef". Signed-off-by: Lance Albertson <lance@osuosl.org>
…ants Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
The default installation directory on MacOS includes "chef_software" which should be configurable for distributions of Chef. Signed-off-by: Lance Albertson <lance@osuosl.org>
The default installation directory on Windows includes "opscode" which should be configurable for distributions of Chef. Signed-off-by: Lance Albertson <lance@osuosl.org>
ramereth
force-pushed
the
community-distribution-fixes
branch
from
October 7, 2019 22:06
cda4266
to
7ce47e5
Compare
miah
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ramereth
tas50
reviewed
Oct 28, 2019
tas50
reviewed
Oct 28, 2019
tas50
reviewed
Oct 28, 2019
Signed-off-by: Lance Albertson <lance@osuosl.org>
ramereth
added a commit
to ramereth/omnitruck
that referenced
this pull request
Dec 15, 2019
This applies some fixes which were introduced in [1] that help support community distributions better. [1] chef/mixlib-install#292 Signed-off-by: Lance Albertson <lance@osuosl.org>
10 tasks
ramereth
added a commit
to ramereth/omnitruck
that referenced
this pull request
Dec 15, 2019
This applies some fixes which were introduced in [1] that help support community distributions better. [1] chef/mixlib-install#292 Signed-off-by: Lance Albertson <lance@osuosl.org>
ramereth
added a commit
to ramereth/omnitruck
that referenced
this pull request
Dec 15, 2019
This applies some fixes which were introduced in [1] that help support community distributions better. Some other fixes include: - Ensure we pull in mixlib-install >= 3.11.23 which includes the patches introduced in [1] - Create dist.rb file for renaming chef to something else and also set the SLES project versions to other names [1] chef/mixlib-install#292 Signed-off-by: Lance Albertson <lance@osuosl.org>
ramereth
added a commit
to ramereth/omnitruck
that referenced
this pull request
Mar 12, 2020
This applies some fixes which were introduced in [1] that help support community distributions better. [1] chef/mixlib-install#292 Signed-off-by: Lance Albertson <lance@osuosl.org>
ramereth
added a commit
to ramereth/omnitruck
that referenced
this pull request
Mar 14, 2020
This applies some fixes which were introduced in [1] that help support community distributions better. Some other fixes include: - Ensure we pull in mixlib-install >= 3.11.23 which includes the patches introduced in [1] - Create dist.rb file for renaming chef to something else and also set the SLES project versions to other names [1] chef/mixlib-install#292 Signed-off-by: Lance Albertson <lance@osuosl.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This provides some fixes which will allow community distributions the ability to easily override various URLs. In addition, this separates out the PRODUCT_MATRIX into it's own file which community distributions could also override as needed.
NOTE: omnitruck will likely need to be updated to pull in the product matrix properly. I will be providing a PR for that soon. I do not believe dependent gems will run into this issue.
Types of changes
Checklist: