Use the VERSION_ID variable by default in /etc/os-release #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable is the machine readable version ID for tools like our install script. The VERSION variable often includes friendly values like this: "7.5 (Maipo)". We're already doing this for RHEL platforms, but currently we pull in VERSION on modern opensuse platforms and others, which breaks installs via install.sh. Lack VERSION (or version without strings in it), but have VERSION_ID: alpine - https://github.com/chef/os_release/blob/master/alpine_3_8 clearos - https://github.com/chef/os_release/blob/master/clearos_7 cumulus - https://github.com/chef/os_release/blob/master/cumulus_3_7 debian - https://github.com/chef/os_release/blob/master/debian_7 elementary - https://github.com/chef/os_release/blob/master/elementary_5 fedora - https://github.com/chef/os_release/blob/master/fedora_28 linuxmint - https://github.com/chef/os_release/blob/master/linuxmint_19 nixos - https://github.com/chef/os_release/blob/master/nixos raspian - https://github.com/chef/os_release/blob/master/raspbian_10 redhat - https://github.com/chef/os_release/blob/master/redhat_7 scientific - https://github.com/chef/os_release/blob/master/scientific_7 sled 12 - https://github.com/chef/os_release/blob/master/sled_12_3 sles 12 - https://github.com/chef/os_release/blob/master/sles_12_3 sles-sap 12 - https://github.com/chef/os_release/blob/master/sles_sap_12_1 ubuntu - https://github.com/chef/os_release/blob/master/ubuntu_1404 XBian - https://github.com/chef/os_release/blob/master/xbian Have VERSION, but not VERSION_ID: Antergos - https://github.com/chef/os_release/blob/master/antergos xenserver - https://github.com/chef/os_release/blob/master/xenserver_7_6 Have neither: arch - https://github.com/chef/os_release/blob/master/arch archarm - https://github.com/chef/os_release/blob/master/archarm gentoo - https://github.com/chef/os_release/blob/master/gentoo manjaro - https://github.com/chef/os_release/blob/master/manjaro nexus7 - https://github.com/chef/os_release/blob/master/nexus_7 Signed-off-by: Tim Smith <tsmith@chef.io>
schisamo
approved these changes
Mar 11, 2020
tas50
added
the
Expeditor: Bump Version Minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable is the machine readable version ID for tools like our install script. The VERSION variable often includes friendly values like this: "7.5 (Maipo)".
We're already doing this for RHEL platforms, but currently we pull in VERSION on modern opensuse platforms and others, which breaks installs via install.sh.
Lack VERSION (or version without strings in it), but have VERSION_ID:
Have VERSION, but not VERSION_ID:
Have neither:
Signed-off-by: Tim Smith tsmith@chef.io