Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip query parameters when determining filename #353

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

gscho
Copy link
Contributor

@gscho gscho commented Mar 17, 2021

Fixes #325

Signed-off-by: gscho greg.c.schofield@gmail.com

Description

Parse filename correctly from URLs with query parameters.

Related Issue

#325

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: gscho <greg.c.schofield@gmail.com>
@gscho gscho requested review from a team as code owners March 17, 2021 14:42
@tas50 tas50 merged commit 7f3cafd into chef:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install PowerShell script errors when using pre-signed url as download url override
3 participants