Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for detecting Windows Server 2022 platform #377

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Add support for detecting Windows Server 2022 platform #377

merged 2 commits into from
Sep 20, 2022

Conversation

decoyjoe
Copy link
Contributor

Description

Add support for detecting Windows Server 2022 platform

Windows Server 2022 was being detected as 2016. Also made the platform
version detection logic more robust.

Signed-off-by: Joseph Larionov jlarionov@webmd.net

Related Issue

Fixes #376

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@decoyjoe
Add support for detecting Windows Server 2022 platform
35ba17a 
Windows Server 2022 was being detected as 2016. Also made the platform
version detection logic more robust.

Signed-off-by: Joseph Larionov <jlarionov@webmd.net>
@decoyjoe decoyjoe requested review from a team as code owners March 25, 2022 22:29
@decoyjoe
Copy link
Contributor Author

Buildkite failed with an error unrelated to my changes:

Gem::RuntimeRequirementNotMetError: vcr requires Ruby version >= 2.6. The
current ruby version is 2.4.10.364.
An error occurred while installing vcr (6.1.0), and Bundler cannot
continue.
Make sure that `gem install vcr -v '6.1.0' --source 'https://rubygems.org/'`
succeeds before bundling.

@decoyjoe
Stop testing against Ruby 2.4 and 2.5
d536a43 
Signed-off-by: Joseph Larionov <jlarionov@webmd.net>
@decoyjoe decoyjoe requested a review from a team as a code owner April 5, 2022 18:56
@tpowell-progress tpowell-progress self-assigned this Aug 30, 2022
@tpowell-progress tpowell-progress merged commit a5718ec into chef:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarve-chef vkarve-chef vkarve-chef approved these changes

@marcparadise marcparadise marcparadise approved these changes

@jaymzh jaymzh jaymzh approved these changes

Assignees

@tpowell-progress tpowell-progress

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add platform version detection for Windows Server 2022
5 participants
@decoyjoe @jaymzh @marcparadise @vkarve-chef @tpowell-progress