Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby 3.0/3.1 tests on windows #378

Merged
merged 5 commits into from
Apr 7, 2022

Conversation

poorndm
Copy link
Contributor

@poorndm poorndm commented Apr 7, 2022

Signed-off-by: poornima poorndm@progress.com

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

poorndm added 4 commits April 7, 2022 14:38
Signed-off-by: poornima <poorndm@progress.com>
Signed-off-by: poornima <poorndm@progress.com>
Signed-off-by: poornima <poorndm@progress.com>
Signed-off-by: poornima <poorndm@progress.com>
@marcparadise marcparadise force-pushed the poorndm/IPACK-66-ADD-WINDOWS-3.1-TEST branch 5 times, most recently from e977394 to 895b665 Compare April 7, 2022 18:46
We used aruba for testing, but it introduces incompatiblites under
Windows w/ Ruby 3.1, via its dependency ChildProcess.  Due to time
and resource constraints we can't dig too deeply into that underlying
issue. Instead, we replace it with mixlib-shellout, and remove the
aruba dependency.

Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
@marcparadise marcparadise force-pushed the poorndm/IPACK-66-ADD-WINDOWS-3.1-TEST branch from 895b665 to 6b54f24 Compare April 7, 2022 18:47
@PrajaktaPurohit PrajaktaPurohit marked this pull request as ready for review April 7, 2022 19:33
@PrajaktaPurohit PrajaktaPurohit requested review from a team as code owners April 7, 2022 19:33
@marcparadise marcparadise merged commit b94184f into main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants