Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match on 64 for architecture because of different languages #380

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Match on 64 for architecture because of different languages #380

merged 1 commit into from
Aug 9, 2022

Conversation

tpowell-progress
Copy link
Contributor

Signed-off-by: Thomas Powell powell@progress.com

Description

Installs on non-English Windows may fail to match on "64-bit" due to localized arch names, but especially non-Latin alphabet versions, e.g., Chinese 64-bit obarchitecture is returned as "64 位"

Match on "64" only for confirming 64-bit install. 32-bit should be the exceptional case at this point, anyway.

Related Issue

INFC-220

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@tpowell-progress
Match on 64 for architecture because of different languages
82fa627 
Signed-off-by: Thomas Powell <powell@progress.com>
@tpowell-progress tpowell-progress requested review from a team as code owners August 5, 2022 19:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@marcparadise marcparadise merged commit 466b6a4 into main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcparadise marcparadise marcparadise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpowell-progress @marcparadise