Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download install sh from new download api #399

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ashiqueps
Copy link
Contributor

Description

The install.sh and install.ps1 files are moved to the new download API and maintained there. If the options has the new key, instead of building the file, download it from the new download api.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
@ashiqueps ashiqueps requested review from a team as code owners October 22, 2024 13:50
Copy link

Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jaymzh
Copy link
Collaborator

jaymzh commented Oct 29, 2024

After discussion, this PR isn't the cause of the failure, so we'll merge.

However, we do need to fix the build, and here's the context, so that it is written down somewhere:

This repo (mixlib-install), is the bootstrap mechanism for folks to get a modern build of ruby from a system ruby which may be old, and may be even an unsupported version. So, we need to look at all supported platforms, determine the oldest system ruby, and then bump our min version to that (or, that may mean keeping it where it is), then fixing our rubygem dependencies to accommodate that version.

@jaymzh jaymzh merged commit 98741b9 into main Oct 29, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants