Support array args on windows #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamont-granquist
force-pushed
the
lcg/win-array-args
branch
from
083e31e to
ac20d79
Compare
lamont-granquist
force-pushed
the
lcg/win-array-args
branch
from
ac20d79 to
ac3b2fb
Compare
|
The appveyor breakage on ruby 2.4/2.5 also exists on master and is unrelated and is a pile of windows WTF: https://ci.appveyor.com/project/chef/mixlib-shellout/builds/25078786 |
zenspider
suggested changes
Jun 6, 2019
zenspider
approved these changes
Jun 6, 2019
Implements correct quoting and escaping of arguments on windows.
That means that this works right now:
```ruby
filename = "c:\program files"
shell_out("dir", filename);
```
So all the defensive coding around quotes-around-filepaths -- which were
all actually buggy even when they worked (trailing backslashes would
fail) -- are unnecessary and arguments can just be passed in as an array
and this code will sort it out.
We rely on the existing determination of if metacharacters mean it needs
to run under cmd and if it needs the ^ quoting which seems to be well
tested, and which all runs after this does.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
lamont-granquist
force-pushed
the
lcg/win-array-args
branch
from
a2b2fe8 to
9b36f24
Compare
zenspider
approved these changes
Jun 6, 2019
lamont-granquist
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements correct quoting and escaping of arguments on windows.
That means that this works right now:
So all the defensive coding around quotes-around-filepaths -- which were
all actually buggy even when they worked (trailing backslashes would
fail) -- are unnecessary and arguments can just be passed in as an array
and this code will sort it out.
We rely on the existing determination of if metacharacters mean it needs
to run under cmd and if it needs the ^ quoting which seems to be well
tested, and which all runs after this does.