shellout_spec: make "current user" independent of the environment #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamont-granquist
approved these changes
Mar 8, 2020
|
@terceiro this commmit needs a DCO signoff for us to accept it. |
There is no guarantee that ENV["USER"] is always present, and in some environments, it's not. Get the current user from Etc.getpwuid, which works even in the absence of any environment variables. Signed-off-by: Antonio Terceiro <asa@terceiro.xyz>
terceiro
force-pushed
the
fix-test-env-user
branch
from
aa5eade to
1d47f8f
Compare
|
@terceiro this commmit needs a DCO signoff for us to accept it.
done
|
|
thanks, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no guarantee that ENV["USER"] is always present, and in some
environments, it's not. Get the current user from Etc.getpwuid, which
works even in the absence of any environment variables.