Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken windows tests #227

Merged
merged 1 commit into from
Jan 25, 2021
Merged

fix broken windows tests #227

merged 1 commit into from
Jan 25, 2021

Conversation

mwrock
Copy link
Member

@mwrock mwrock commented Nov 17, 2020

This fixes broken windows tests by:

  1. Running docker build as NT AUTHORITY\SYSTEM which will have sufficient privileges to impersonate users.
  2. Copying Powershell.exe instead of ruby.exe to a command with a space. Some (likely most) ruby distributions like the one in the buildkite docker image will also need several DLLs copied along with the exe in order to work. Powershell does not have that problem.

@mwrock mwrock changed the title WIP: troubleshooting tests fix broken windows tests Nov 18, 2020
@mwrock mwrock marked this pull request as ready for review November 18, 2020 19:21
@mwrock mwrock requested review from a team as code owners November 18, 2020 19:21
Signed-off-by: mwrock <matt@mattwrock.com>
Copy link
Contributor

@phiggins phiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce! 👍

@lamont-granquist lamont-granquist merged commit 9581c70 into main Jan 25, 2021
@lamont-granquist lamont-granquist deleted the tests branch January 25, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants