Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen platform regex to allow 64 or 32 bit mingw #234

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Loosen platform regex to allow 64 or 32 bit mingw #234

merged 1 commit into from
Mar 29, 2022

Conversation

clintoncwolfe
Copy link
Contributor

Signed-off-by: Clinton Wolfe clintoncwolfe@gmail.com

Causing test failures on InSpec here (not our only problem) - https://buildkite.com/chef-oss/inspec-inspec-main-verify/builds/4314#4c315e88-e205-42dc-8536-22aae8fef418

Description

Related Issue

Fixes #233

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@clintoncwolfe
Naively loosen platform regex to allow 64 or 32 bit mingw
91da93e 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
PrajaktaPurohit
PrajaktaPurohit approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@PrajaktaPurohit PrajaktaPurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need to continue testing on ruby 2.4? Looks like there is a failure there.

@PrajaktaPurohit PrajaktaPurohit merged commit e6ba621 into chef:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajaktaPurohit PrajaktaPurohit PrajaktaPurohit approved these changes

@lamont-granquist lamont-granquist lamont-granquist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows is misidentified on Ruby 3.1
3 participants
@clintoncwolfe @lamont-granquist @PrajaktaPurohit