[Unix#run_command] Remove Ruby 1.8.7 check #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafyddcrosby
force-pushed
the
runcommand_rm_187
branch
from
8fac9a2 to
1f72acc
Compare
dafyddcrosby
force-pushed
the
runcommand_rm_187
branch
2 times, most recently
from
798468f to
024bef3
Compare
jaymzh
approved these changes
Jun 11, 2024
Signed-off-by: David Crosby <dcrosby@fb.com>
dafyddcrosby
force-pushed
the
runcommand_rm_187
branch
from
024bef3 to
5e9ddd4
Compare
|
tpowell-progress
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.8.7 is... quite old. No need to check anymore since it's EOL and not supported by the gemspec.
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.