Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep ffi version below 1.17 #244

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Keep ffi version below 1.17 #244

merged 2 commits into from
Jun 8, 2024

Conversation

tpowell-progress
Copy link
Contributor

@tpowell-progress tpowell-progress commented Jun 7, 2024

Description

  • ffi 1.17 and beyond requires a newer RubyGems than is installed with the ruby versions we are using.
  • Remove tests for Ruby < 2.7
  • Remove Gemfile conditional for Ruby < 2.7

Related Issue

See also ffi/ffi#1106

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@tpowell-progress tpowell-progress requested review from a team as code owners June 7, 2024 13:25
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@tpowell-progress tpowell-progress requested a review from a team as a code owner June 7, 2024 13:30
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@poorndm poorndm merged commit ef255ac into main Jun 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants