The detection of Parallels virtualization added. #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| describe Ohai::System, "Darwin virtualization platform" do | ||
| before(:each) do | ||
| @plugin = get_plugin("darwin/virtualization") |
There was a problem hiding this comment.
We prefer to use :let instead of instance variables in before(:each) blocks. Check out the "Use let and let!" subsection of Better Specs.
|
Looks good @Kasen ! Only thing missing is a windows virtualization spec. Are you up for writing that? If not, I can help out. |
|
@mcquin I think I fixed what you asked for |
|
LGTM 👍 Big thanks for adding a Windows virt plugin spec.
|
|
@thommay, review please |
|
Thanks for your contribution! I've no way of testing this but the code looks good, merging. |
thommay
added a commit
that referenced
this pull request
Jun 24, 2015
The detection of Parallels virtualization added.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallels Desktop is product for desktop virtualization for Mac such as VMware fusion.
This PR adds the support of detection Parallels Desktop as host system on Mac and as guest system on Mac, Windows and Linux.