Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored reverted patch to make for Ubuntu 18.04, Debian 10 and Raspbian only #1094

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Conversation

mattray
Copy link
Contributor

@mattray mattray commented Sep 13, 2019

Still an issue, but now the patch has a narrower scope.

See
#1085
and
cca7d82

Signed-off-by: Matt Ray matthewhray@gmail.com

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@mattray mattray requested review from a team as code owners September 13, 2019 22:02
Copy link

@scotthain scotthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you submit the patch in the standard format in the patches directory rather than a sed command? That would make this far easier to understand and follow the standard.

…ian-only

Signed-off-by: Matt Ray <matthewhray@gmail.com>
Signed-off-by: Matt Ray <matthewhray@gmail.com>
@mattray
Copy link
Contributor Author

mattray commented Oct 18, 2019

I'm not sure how to mark that I've made the changes requested, but please review again.

@tas50
Copy link
Contributor

tas50 commented Oct 18, 2019

Ping @scotthain

@mattray mattray requested a review from scotthain October 20, 2019 10:23
Copy link

@scotthain scotthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay.

@scotthain scotthain merged commit 433a18f into chef:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants