Updating freebsd to omit the devcrypto engine which is breaking

[johnmccrae]

In compiling Ruby 3.0.4 out for an updated Chef 17.0.149 build we encountered a couple of issues. First, compilation for openssl was dying and causing the builder to spit this error message out:

gmake[2]: Leaving directory '/var/cache/omnibus/chef/src/openssl/openssl-1.0.2zi/crypto/engine'
--
  | gmake[1]: Leaving directory '/var/cache/omnibus/chef/src/openssl/openssl-1.0.2zi/crypto'
  |  
  | Error:
  |  
  | eng_cryptodev.c:250:19: error: use of undeclared identifier 'CRIOGET'
  | 250 \|     if (ioctl(fd, CRIOGET, &retfd) == -1)
  | \|                   ^
  | 1 error generated.

if you search on the "eng_cryptodev.c... " in the error output above you get exactly 1 hit from Google which is the patch put out by Freebsd.org that tells you how to fix this: Go Here

The only issue with that patch is that it adds a version constraint limiting devcrypto to Freebsd 13 or less. The workaround for that moving forward is to simply add dev crypto to your modules list and voila!

Description

Related Issue

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[tpowell-progress]

Need to document in the PR description the findings that led to this solution, as well as in a squashed commits or above line 164 in openssl.rb

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud