Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify spec file - unpin train-core #1925

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

poorndm
Copy link
Collaborator

@poorndm poorndm commented Jul 25, 2024

Description

The latest version of the train-core gem (3.12.6) includes a fix for the issue present in version 3.12.5. We need to revert the changes made to pin the version for Ruby <= 3.1 in the omnibus and omnibus-software repositories.
Current Configuration:
if Gem::Version.new(RUBY_VERSION) <= Gem::Version.new("3.1.0")
s.add_dependency "train-core", "<3.12.5"

  • train-core version 3.12.6 requires Ruby version >= 2.7.
  • train-core version 3.12.5 required Ruby version >= 3.1.
    Hence Revert the pinned train-core version changes for Ruby <= 3.1 omnibus-software

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: poorndm <poorndm@progress.com>
Copy link

sonarcloud bot commented Jul 25, 2024

@poorndm poorndm marked this pull request as ready for review July 25, 2024 07:12
@poorndm poorndm requested review from a team as code owners July 25, 2024 07:12
@poorndm poorndm merged commit b73b772 into main Jul 25, 2024
6 checks passed
@poorndm poorndm deleted the poorndm/revert-train-core-changes branch July 25, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants