Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a definition for Train #762

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Adding a definition for Train #762

merged 1 commit into from
Nov 8, 2016

Conversation

tyler-ball
Copy link
Contributor

Description

https://github.com/chef/train - The transport layer!


/cc @chef/omnibus-maintainers <- This ensures the Omnibus Maintainers team are notified to review this PR.

Copy link

@scotthain scotthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah! 🚋

Signed-off-by: tyler-ball <tyleraball@gmail.com>
@stevendanna
Copy link
Contributor

What is the planned use for this? I'm not against it, just wondering why this can't be pulled in via bundler in places where it is needed?

@tyler-ball
Copy link
Contributor Author

@stevendanna So I actually will end up pulling it in via Bundler eventually.

Right now Inspec is pinned to ">= 0.20.1" of Train. We include Inspec via the software definition. It occurs early in our build so will pull in version 0.21.0 of Train. I want to pin to version 0.20.1 to avoid a Train bug.

To do that the easiest thing I know of is to include the train software definition earlier in the build order than inspec and pin Train to the version I want. Then Inspec will use the existing version of Train.

@stevendanna
Copy link
Contributor

okie dokie.

@tyler-ball
Copy link
Contributor Author

I've got 2 responses to this - is that enough for me to merge this?

Copy link
Contributor

@schisamo schisamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tyler-ball tyler-ball merged commit 717f21e into master Nov 8, 2016
@tyler-ball tyler-ball deleted the train branch November 8, 2016 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants