Add gems for ECC algorithm support. #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lamont-granquist
approved these changes
Jan 19, 2017
thommay
approved these changes
Jan 19, 2017
stevendanna
reviewed
Jan 19, 2017
| @@ -0,0 +1,40 @@ | |||
| # | |||
| # Copyright 2012-2014 Chef Software, Inc. | |||
There was a problem hiding this comment.
nit: might want to update the dates here
stevendanna
approved these changes
Jan 19, 2017
These definitions have been added to resolve build issues with ECC algorithm support. The bcyrpt_pbkdf gem currently link against shared libs which are not installed on Cisco IOS-XR. The rbnacl-libsodium gem currently fails to compile on Solaris for both x86-64 and SPARC architectures. Adding these definitions will allow us to selectively define the supported platforms as well as provide a simple means to itterate on patches as needed. Signed-off-by: Ryan Hass <rhass@users.noreply.github.com> Signed-off-by: Tom Duffield <tom@chef.io>
tduffield
force-pushed
the
rhass/COOL-657_ecc-algorithm-support
branch
from
d04fd6e to
5a064eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These definitions have been added to resolve build issues with ECC algorithm support.
The bcyrpt_pbkdf gem currently link against shared libs which are not installed on Cisco IOS-XR.
The rbnacl-libsodium gem currently fails to compile on Solaris for both x86-64 and SPARC architectures.
Adding these definitions will allow us to selectively define the supported platforms as well as provide a simple means to iterate on patches as needed.
/cc @chef/omnibus-maintainers