Pin to Ohai gem < 17 #1013
Merged
Pin to Ohai gem < 17 #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ohai 17 requires Ruby 2.7+ but we currently ship Ruby 2.6 inside of Omnibus Toolchain. This pinning of Ohai should be viewed as a temporary fix until we can ship a new version of Omnibus Toolchain which contains Ruby 2.7+. Signed-off-by: Seth Chisamore <schisamo@chef.io>
nkierpiec
approved these changes
Apr 28, 2021
balasankarc
added a commit
to balasankarc/omnibus
that referenced
this pull request
Oct 8, 2021
The restricton `< 17` was originally added by 2777c5b in chef#1013 because `omnibus-toolchain` was still shipping Ruby 2.6 at that time, and Ohai 17 required Ruby 17. However, starting with chef/omnibus-toolchain#153, `omnibus-toolchain` is on Ruby 2.7+, and hence this restriction can be removed. Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
balasankarc
added a commit
to balasankarc/omnibus
that referenced
this pull request
Oct 8, 2021
The restricton `< 17` was originally added by 2777c5b in chef#1013 because `omnibus-toolchain` was still shipping Ruby 2.6 at that time, and Ohai 17 required Ruby 17. However, starting with chef/omnibus-toolchain#153, `omnibus-toolchain` is on Ruby 2.7+, and hence this restriction can be removed. Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
balasankarc
added a commit
to balasankarc/omnibus
that referenced
this pull request
Oct 8, 2021
The restricton `< 17` was originally added by 2777c5b in chef#1013 because `omnibus-toolchain` was still shipping Ruby 2.6 at that time, and Ohai 17 required Ruby 17. However, starting with chef/omnibus-toolchain#153, `omnibus-toolchain` is on Ruby 2.7+, and hence this restriction can be removed. To be on the safe side, we are bumping the upper limit to 18 to avoid any surprises when next major version of Ohai comes out. Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
johnmccrae
pushed a commit
that referenced
this pull request
Sep 28, 2022
The restricton `< 17` was originally added by 2777c5b in #1013 because `omnibus-toolchain` was still shipping Ruby 2.6 at that time, and Ohai 17 required Ruby 17. However, starting with chef/omnibus-toolchain#153, `omnibus-toolchain` is on Ruby 2.7+, and hence this restriction can be removed. To be on the safe side, we are bumping the upper limit to 18 to avoid any surprises when next major version of Ohai comes out. Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ohai 17 requires Ruby 2.7+ but we currently ship Ruby 2.6 inside of
Omnibus Toolchain. This pinning of Ohai should be viewed as a temporary
fix until we can ship a new version of Omnibus Toolchain which contains
Ruby 2.7+.
Signed-off-by: Seth Chisamore schisamo@chef.io
Description
Briefly describe the new feature or fix here
Maintainers
Please ensure that you check for:
serial number
corresponding change is reviewed and there is a release plan
corresponding change is reviewed and there is a release plan