Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates rpm spec to use SHA256 for filedigest, from MD5 #1027

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Updates rpm spec to use SHA256 for filedigest, from MD5 #1027

merged 1 commit into from
Jul 15, 2021

Conversation

collinmcneese
Copy link
Contributor

Signed-off-by: Collin McNeese cmcneese@chef.io

Description

Updates the RPM spec for packaging to use SHA256 for the file digest algorithm instead of MD5. This should allow support of RPM package installation on EL8-variant systems with FIPS-mode enabled.

Referenced in issue from chef/chef#11790

thanks to @teknofire for the assistance in where the logic is running via omnibus

Maintainers

Please ensure that you check for:

  • [] If this change impacts git cache validity, it bumps the git cache
    serial number
  • [] If this change impacts compatibility with omnibus-software, the
    corresponding change is reviewed and there is a release plan
  • [] If this change impacts compatibility with the omnibus cookbook, the
    corresponding change is reviewed and there is a release plan

Signed-off-by: Collin McNeese <cmcneese@chef.io>
@collinmcneese collinmcneese requested review from a team as code owners July 7, 2021 16:17
@tas50
Copy link
Contributor

tas50 commented Jul 15, 2021

@collinmcneese there's a spec failure here

@tas50 tas50 merged commit e89dee4 into chef:master Jul 15, 2021
@tas50
Copy link
Contributor

tas50 commented Jul 15, 2021

I suspect the reason we didn't do this originally was RHEL 5. It looks like it works fine on RHEL 6+. We'll see when we bring it into chef/chef.

@collinmcneese
Copy link
Contributor Author

@collinmcneese there's a spec failure here

Yeah that was strange, there is no reason that should have failed, perhaps something transient with artifactory at the time

@collinmcneese collinmcneese deleted the cmcnese/rpm_sha256 branch July 15, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants