Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pathing for go on windows #1034

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Fix pathing for go on windows #1034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/omnibus/builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,11 +314,11 @@ def compiler_safe_path(*pieces)
#
def go(command, options = {})
build_commands << BuildCommand.new("go `#{command}'") do
bin = embedded_bin("go")
bin = windows? ? windows_safe_path("#{install_dir}/embedded/go/bin/go") : embedded_bin("go")

# Check if we are building a go binary and then check if we are on
# Red Hat or CentOS so we build the binary properly with a build-id
if command.start_with?("build", " build") && (rhel? || centos?)
if command.start_with?("build", " build") && rhel?
command << " -ldflags=-linkmode=external"
end

Expand Down