Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dependency on nokogiri with rexml #1070

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

jeremiahsnapp
Copy link
Contributor

aws-sdk-s3 needs a gem that can parse xml.
nokogiri requires native extensions to be built which
can be problematic on some platforms (e.g. AIX).
The rexml gem is less performant but it doesn't require native extensions.

Signed-off-by: Jeremiah Snapp jeremiah@chef.io

Description

Briefly describe the new feature or fix here


Maintainers

Please ensure that you check for:

  • [] If this change impacts git cache validity, it bumps the git cache
    serial number
  • [] If this change impacts compatibility with omnibus-software, the
    corresponding change is reviewed and there is a release plan
  • [] If this change impacts compatibility with the omnibus cookbook, the
    corresponding change is reviewed and there is a release plan

aws-sdk-s3 needs a gem that can parse xml.
nokogiri requires native extensions to be built which
can be problematic on some platforms (e.g. AIX).
The rexml gem is less performant but it doesn't require native extensions.

Signed-off-by: Jeremiah Snapp <jeremiah@chef.io>
@jeremiahsnapp jeremiahsnapp requested a review from a team as a code owner May 26, 2022 14:42
@sonarcloud
Copy link

sonarcloud bot commented May 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@skeshari12 skeshari12 merged commit c3c9d11 into main May 26, 2022
@skeshari12 skeshari12 deleted the jsnapp/IPACK-204 branch May 26, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants