Add "cached_name" option for net fetcher #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legal90
force-pushed
the
fix-fname-collision
branch
from
ed39ae4
to
b381fd7
Compare
legal90
force-pushed
the
fix-fname-collision
branch
from
b381fd7
to
5d4ee5c
Compare
|
Is anyone interested in this fix? |
|
Ping @scotthain |
It is needed to work around possible name collisions of filename in local cache. Signed-off-by: Mikhail Zholobov <legal90@gmail.com>
legal90
force-pushed
the
fix-fname-collision
branch
from
5d4ee5c
to
46a5346
Compare
|
@scotthain Sure! Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #836
I've added
cached_nameoption forSoftware#sourceallowing to specify a custom filename for the source file when it is stored in the local cache. So that it could be used to work aroung a name collision issue described in #836