Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added localization option for msi packager #854

Merged
merged 5 commits into from
Mar 28, 2019
Merged

Conversation

MrWong99
Copy link
Contributor

@MrWong99 MrWong99 commented Sep 10, 2018

Description

WIX allows users to configure the target localization.
This feature allows a user to override the default localization en-us for the msi packager.
The project generator for msi was not changed, but one could generate the localization files for each supported language based on the standard implementations of wix.

Maintainers

Please ensure that you check for:

  • If this change impacts git cache validity, it bumps the git cache
    serial number
  • If this change impacts compatibility with omnibus-software, the
    corresponding change is reviewed and there is a release plan
  • If this change impacts compatibility with the omnibus cookbook, the
    corresponding change is reviewed and there is a release plan

Signed-off-by: Lukas Schmidt <Lukas.Schmidt@kisters.de>
@MrWong99 MrWong99 requested a review from a team as a code owner September 10, 2018 12:04
@MrWong99
Copy link
Contributor Author

Any comment on this? How can I help to get this merged?
Or should I build my own Omnibus gem?

@marcparadise
Copy link
Member

Thanks for submitting this @MrWong99, and sorry for the delay in getting eyes on this.

Would you be able to recreate this branch based on current master? We should be able to get it merged shortly after.

@marcparadise marcparadise self-assigned this Mar 27, 2019
@marcparadise marcparadise added the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Mar 27, 2019
Merge master into feature branch
@MrWong99
Copy link
Contributor Author

Hi @marcparadise and thanks for your response!

I merged the master branch in my feature branch and the CI checks seem to be satisfied.

@marcparadise
Copy link
Member

Excellent, thanks!

@marcparadise marcparadise removed the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Mar 28, 2019
@scotthain scotthain merged commit 349319a into chef:master Mar 28, 2019
@MrWong99
Copy link
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants