Unpin gcc-4.8 for later versions of Suse #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotthain
approved these changes
Oct 9, 2018
lib/omnibus/software.rb
Outdated
| @@ -700,7 +700,7 @@ def with_standard_compiler_flags(env = {}, opts = {}) | |||
| "CFLAGS" => "-I#{install_dir}/embedded/include -O2", | |||
| } | |||
| # Enable gcc version 4.8 if it is available | |||
| if which("gcc-4.8") | |||
| if which("gcc-4.8") && platform_version.satisfies?("<= 11.4") | |||
There was a problem hiding this comment.
Let's make this < 12, just in case there's ever an 11.5
Signed-off-by: Jaymala Sinha <jsinha@chef.io>
jaymalasinha
force-pushed
the
jsinha/fix-suse-gccpin
branch
from
f46e047
to
3bc81bb
Compare
|
@scotthain updated as per your review comment. |
scotthain
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jaymala Sinha jsinha@chef.io
Description
Suse platform versions later than 12 should compile using the default gcc version.
Only use gcc-4.8 for Suse platforms before version 12.
Maintainers
Please ensure that you check for:
serial number
corresponding change is reviewed and there is a release plan
corresponding change is reviewed and there is a release plan