Pin ffi to < 0.13 for windows #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiahsnapp
approved these changes
Jun 3, 2020
jaymalasinha
reviewed
Jun 3, 2020
There was a problem hiding this comment.
👍 Thanks for this PR. Can you please fix https://buildkite.com/chef-oss/chef-omnibus-master-verify/builds/187#c960348e-4630-4280-969b-3918385b4ba0/367-374. (Rubocop errors)
|
Thanks @jaymalasinha - I pushed a fix for that rubocop violation |
ffi 0.13 crashes Ruby on windows - see ffi/ffi#784 Signed-off-by: James Stocks <jstocks@chef.io>
jaymalasinha
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffi 0.13 crashes Ruby on windows - see ffi/ffi#784
Example of the crash for InSpec:
https://buildkite.com/chef/inspec-inspec-master-omnibus-release/builds/265#a71f492b-abe1-4b53-8f3a-15fd1cac69a8/94-168
inspec/inspec#5065 demonstrates the ffi pin getting the Windows build working again, but I think the pin should be here in omnibus rather than in individual projects.
Signed-off-by: James Stocks jstocks@chef.io