Add support for writing call metadata to an adjacent JSON file #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON file contains all of the metadata known to BCR (which roughly matches the information that can be used in the filename templates). This feature is disabled by default. The majority of this commit is splitting the call metadata collection out of OutputFilenameGenerator. This is something that should've been done anyway. The notification delete button logic has also been reworked so that the metadata file is also deleted. If debug mode is enabled, the log file will now also be deleted. Closes: #380 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Jul 20, 2023
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON file contains all of the metadata known to BCR (which roughly matches the information that can be used in the filename templates). This feature is disabled by default.
The majority of this commit is splitting the call metadata collection out of OutputFilenameGenerator. This is something that should've been done anyway.
The notification delete button logic has also been reworked so that the metadata file is also deleted. If debug mode is enabled, the log file will now also be deleted.
Closes: #380