Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password-based remotes don't work #7

Closed
SigmaBonder opened this issue Jun 19, 2023 · 3 comments · Fixed by #13
Closed

Password-based remotes don't work #7

SigmaBonder opened this issue Jun 19, 2023 · 3 comments · Fixed by #13
Assignees

Comments

@SigmaBonder
Copy link

In the rclone config file, human-readable passwords have to be obscured.
Currently, they don't seem to be, which results in this error when trying to use password-based remotes like SSH:
input too short when revealing password - is it obscured?
I hope I'm not exaggerating this issue here, as the only password-based remote I tested was SSH, but it seems reasonable to assume that the issue will be common to all of those.

@chenxiaolong
Copy link
Owner

Thanks, I'm able to reproduce this with SMB. I'll investigate.

@chenxiaolong chenxiaolong self-assigned this Jun 19, 2023
@chenxiaolong
Copy link
Owner

Looks like this is a bug in rclone. I can reproduce it on the command line.

In one terminal:

rclone rcd --rc-no-auth

In another terminal:

rclone config create test smb --non-interactive --all
# Hostname
rclone config update test --non-interactive --continue --state "*all-set,0,false" --result hostname --all
# Username
rclone config update test --non-interactive --continue --state "*all-set,1,false" --result username --all
# Port number
rclone config update test --non-interactive --continue --state "*all-set,2,false" --all
# Password
rclone config update test --non-interactive --continue --state "*all-set,3,false" --result foobar --obscure --all

Resulting config:

$ cat ~/.config/rclone/rclone.conf
[test]
type = smb
host = hostname
user = username
port =
pass = foobar

Seems like rclone doesn't respect the --obscure flag in the configuration API. (RSAF uses the same option, but programmatically.) I'll see if I can work around this.

@chenxiaolong
Copy link
Owner

I submitted an upstream bug report for this: rclone/rclone#7069 I'll make RSAF explicitly obscure the password in the meantime.

chenxiaolong added a commit that referenced this issue Jun 19, 2023
Currently, even if `obscure` is set to `true`, the value passed via the
`result` parameter to the `config/update` RPC call is used verbatim.

Upstream bug report: rclone/rclone#7069

Fixes: #7

Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants