Add support for DocumentsProvider.openDocumentThumbnail() #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will return a pipe and then spawn a background task to generate a thumbnail and write it to the pipe. Cancellation is supported in between logical operations (eg. parse headers, load frame, etc.). Android has no way to interrupt the parsers in MediaMetadataRetriever and ImageDecoder though, so there will be a delay before cancellation takes effect. This can be noticeable when scrolling quickly, for example through a list of videos, since there is a hard concurrency limit equal to the number of logical cores. Note that only audio, image, and video formats natively supported by Android can be thumbnailed. We don't bundle any decoders. Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
force-pushed
the
thumbnail
branch
from
5884b3e to
1b41b95
Compare
chenxiaolong
added a commit
that referenced
this pull request
Dec 20, 2024
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will return a pipe and then spawn a background task to generate a thumbnail and write it to the pipe. Cancellation is supported in between logical operations (eg. parse headers, load frame, etc.). Android has no way to interrupt the parsers in
MediaMetadataRetrieverandImageDecoderthough, so there will be a delay before cancellation takes effect. This can be noticeable when scrolling quickly, for example through a list of videos, since there is a hard concurrency limit equal to the number of logical cores.Note that only audio, image, and video formats natively supported by Android can be thumbnailed. We don't bundle any decoders.