isChildDocument(): Normalize paths before comparison #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, duplicate and trailing slashes can result in an incorrect return value, which breaks apps that perform URI manipulation instead of using URIs returned by SAF. This commit partially reverts 78cf92a also. If the parent and child refer to the same path, isChildDocuments() will now return true. This is counter to what the SAF documentation says, but AOSP's FileSystemProvider behaves this way and apps now rely on that behavior. Fixes: #44 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Dec 22, 2023
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, duplicate and trailing slashes can result in an incorrect return value, which breaks apps that perform URI manipulation instead of using URIs returned by SAF.
This commit partially reverts 78cf92a also. If the parent and child refer to the same path, isChildDocuments() will now return true. This is counter to what the SAF documentation says, but AOSP's FileSystemProvider behaves this way and apps now rely on that behavior.
Fixes: #44