rcbridge: Avoid calling Android functions over JNI #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since go 1.22.5, this results in a panic. There is an upstream bug report at [1] for musl, but the same thing happens with bionic. The same fix of using pthread_getattr_np() on bionic also works, but it's better to avoid needing folks to recompile the go toolchain. We were just using these calls as a small hack to pass a list of structs to the Java side, which we can easily do another way. [1] golang/go#68285 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Jul 20, 2024
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since go 1.22.5, this results in a panic. There is an upstream bug report at [1] for musl, but the same thing happens with bionic. The same fix of using pthread_getattr_np() on bionic also works, but it's better to avoid needing folks to recompile the go toolchain.
We were just using these calls as a small hack to pass a list of structs to the Java side, which we can easily do another way.
[1] golang/go#68285