Make dynamic shortcuts configurable #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the user can choose which remotes they want shortcuts for. Previously, the visibility was tied to whether external app access was blocked. The default state for this new option is to not add a shortcut. The state is saved in rclone.conf so it is preserved when exporting and reimporting a config. This commit also fixes RSAF crashing when the number of shortcuts exceeds Android's limit (usually 15). If there are too many shortcuts, the list will now be silently truncated. There is no UI warning for this because the user-facing limit is the launcher's limit (usually 4), which is way less than Android's limit and there's no API for querying it. It doesn't make sense to show a warning long after the launcher already started hiding shortcuts. Fixes: #65 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Sep 2, 2024
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the user can choose which remotes they want shortcuts for. Previously, the visibility was tied to whether external app access was blocked. The default state for this new option is to not add a shortcut. The state is saved in rclone.conf so it is preserved when exporting and reimporting a config.
This commit also fixes RSAF crashing when the number of shortcuts exceeds Android's limit (usually 15). If there are too many shortcuts, the list will now be silently truncated. There is no UI warning for this because the user-facing limit is the launcher's limit (usually 4), which is way less than Android's limit and there's no API for querying it. It doesn't make sense to show a warning long after the launcher already started hiding shortcuts.
Fixes: #65