Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement flexibility on resolver to cycle between methods using ? to transform keys [DEV-2208] #137

Merged
merged 52 commits into from
Apr 23, 2023
Merged

feat: Implement flexibility on resolver to cycle between methods using ? to transform keys [DEV-2208] #137

merged 52 commits into from
Apr 23, 2023

Conversation

abdulla-ashurov
Copy link
Contributor

@abdulla-ashurov abdulla-ashurov commented Apr 14, 2023 •
edited
Loading

  • Added implementation for supporting transformKey query
  • Added unit & integration tests
  • Added correct make commands for running unit and integration tests

Andrew Nikitin and others added 19 commits April 3, 2023 16:07
Add handling for only did queries and small refactoring
3aa4ffa
Makes linter happy
0e25625
Add unit tests
df549e5
Add basic implementation for resource queries
7a373ee
Small refactoring
2fe3edb
Add resourceVersion and handler for it
2f91293
Makes Linter happy
aaff569
Makes linter happy
0a7793a
Small refactoring
7d07b7f
Merge remote-tracking branch 'origin/develop' into DEV-2351
b40cdf7
Merge remote-tracking branch 'origin/develop' into DEV-2351
ce6b42c
Fix unit tests for queries
94385c6
MAkes linter happy and fix integration tests
c8ba3f9
Add more integration tests for queries
795fa06
Fixed:
09d3d76 
- added version support
- changed logic for allowing versionId and versionTime in the same query
- added more integration tests
@abdulla-ashurov
Add common functions and constants for transforming
2fb0a75 
key.
@abdulla-ashurov
Add implementation for supporting transformKey
6f1cc5c 
query.
@abdulla-ashurov
Fix golangci-lint mistakes.
aea4372
@abdulla-ashurov
Add correct commands for running unit and
2e6b486 
integration tests.
@abdulla-ashurov abdulla-ashurov added the enhancement New feature or request label Apr 14, 2023
@abdulla-ashurov abdulla-ashurov self-assigned this Apr 14, 2023
@ankurdotb
Copy link
Contributor

Task linked: DEV-2351 DID URL dereferencing parameters (paths, queries) and Resource queries

@ankurdotb
Copy link
Contributor

Task linked: DEV-2208 Implement flexibility on resolver to cycle between methods using ? to transform keys

@abdulla-ashurov abdulla-ashurov temporarily deployed to staging April 14, 2023 14:31 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging April 17, 2023 05:53 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov marked this pull request as ready for review April 19, 2023 12:18
@abdulla-ashurov
Fix problem with go-releaser:
a88dcd1 
- problem was with command: "goreleaser build --clean --snapshot
--single-target"
- I fix that problem with run above go-releaser command manually and
that command run all make commands after that operation it updates
swagger files that were problem.
@abdulla-ashurov
Refactor code and integration tests.
2a24208
@abdulla-ashurov
Update transformKey query payloads.
a610dd3
@abdulla-ashurov
Add integration tests for testing transformKey
36e543f 
query with old 16/32 chars style DIDs.
@abdulla-ashurov
Rename file from "transform_key_suite_test.go" to
10cfabf 
"suite_test.go".
@abdulla-ashurov
Remove debug println.
0010cf3
@abdulla-ashurov
Update did/versions integration tests payloads.
cb77d9f
@abdulla-ashurov
Fix problem with go-releaser.
87f1bb0
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging April 19, 2023 15:01 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging April 19, 2023 15:21 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging April 19, 2023 15:33 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging April 19, 2023 15:42 — with GitHub Actions Inactive
Base automatically changed from DEV-2351 to develop April 20, 2023 15:08
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging April 21, 2023 07:44 — with GitHub Actions Inactive
@lampkin-diet lampkin-diet temporarily deployed to staging April 21, 2023 08:11 — with GitHub Actions Inactive
lampkin-diet
lampkin-diet reviewed Apr 21, 2023
View reviewed changes
Copy link
Contributor

@lampkin-diet lampkin-diet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Let's make some changes and merge it

Makefile Show resolved Hide resolved
services/diddoc/diddoc_query.go Outdated Show resolved Hide resolved
services/diddoc/queries/diddoc/did_query_transform_key_handler.go Show resolved Hide resolved
tests/constants/constants.go Outdated Show resolved Hide resolved
tests/integration/rest/diddoc/query/positive_diddoc_service_test.go Show resolved Hide resolved
services/diddoc/queries/diddoc/utils.go Show resolved Hide resolved
services/diddoc/queries/diddoc/utils.go Show resolved Hide resolved
services/diddoc/queries/diddoc/utils.go Show resolved Hide resolved
services/diddoc/queries/diddoc/utils.go Show resolved Hide resolved
services/diddoc/queries/diddoc/utils.go Show resolved Hide resolved
@abdulla-ashurov
Copy link
Contributor Author

Great job! Let's make some changes and merge it

Thanks for the review! 🙃

@abdulla-ashurov abdulla-ashurov temporarily deployed to staging April 21, 2023 13:28 — with GitHub Actions Inactive
@lampkin-diet lampkin-diet merged commit 9ae8311 into develop Apr 23, 2023
@lampkin-diet lampkin-diet deleted the DEV-2208-transform-key branch April 23, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lampkin-diet lampkin-diet lampkin-diet approved these changes

Assignees

@abdulla-ashurov abdulla-ashurov

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdulla-ashurov @ankurdotb @lampkin-diet