Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use API package cheqd-node instead of import full cheqd-node [DEV-2198] #98

Merged
merged 23 commits into from
Mar 6, 2023
Merged

feat: Use API package cheqd-node instead of import full cheqd-node [DEV-2198] #98

merged 23 commits into from
Mar 6, 2023

Conversation

abdulla-ashurov
Copy link
Contributor

DEV-2198 Use API package cheqd-node instead of import full cheqd-node

  • Added implementation for using API package cheqd-node instead of import full cheqd-node

@abdulla-ashurov abdulla-ashurov self-assigned this Feb 8, 2023
@ankurdotb
Copy link
Contributor

Task linked: DEV-2198 Use API package cheqd-node instead of import full cheqd-node

@abdulla-ashurov abdulla-ashurov temporarily deployed to staging February 10, 2023 10:05 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging February 10, 2023 11:32 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging February 10, 2023 11:41 — with GitHub Actions Inactive
@ankurdotb ankurdotb changed the title chore: DEV-2198 Use API package cheqd-node instead of import full cheqd-node feat: DEV-2198 Use API package cheqd-node instead of import full cheqd-node Feb 13, 2023
@ankurdotb ankurdotb changed the title feat: DEV-2198 Use API package cheqd-node instead of import full cheqd-node feat: Use API package cheqd-node instead of import full cheqd-node [DEV-2198] Feb 13, 2023
lampkin-diet
lampkin-diet suggested changes Feb 13, 2023
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
services/ledger_service.go Outdated Show resolved Hide resolved
types/did_doc_metadata.go Outdated Show resolved Hide resolved
types/did_doc_metadata.go Outdated Show resolved Hide resolved
utils/did_url.go Outdated Show resolved Hide resolved
@abdulla-ashurov
Rename these alias:
0c85fef 
- from "did" to "didTypes"
- from "resource" to "resourceTypes"
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging February 16, 2023 07:01 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging February 16, 2023 08:01 — with GitHub Actions Inactive
@lampkin-diet lampkin-diet temporarily deployed to staging March 3, 2023 15:46 — with GitHub Actions Inactive
@abdulla-ashurov
Fix unit tests error.
ae76302 
-  The method takes an id as first argument instead of a resourceId.
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging March 6, 2023 04:40 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging March 6, 2023 05:00 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging March 6, 2023 05:42 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging March 6, 2023 06:23 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging March 6, 2023 06:42 — with GitHub Actions Inactive
@abdulla-ashurov abdulla-ashurov temporarily deployed to staging March 6, 2023 06:45 — with GitHub Actions Inactive
lampkin-diet
lampkin-diet approved these changes Mar 6, 2023
View reviewed changes
tests/unit-tests/test_utils.go Show resolved Hide resolved
@lampkin-diet lampkin-diet merged commit 712480c into develop Mar 6, 2023
@lampkin-diet lampkin-diet deleted the DEV-2198-re-arch-resolver branch March 6, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lampkin-diet lampkin-diet lampkin-diet approved these changes

Assignees

@abdulla-ashurov abdulla-ashurov

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdulla-ashurov @ankurdotb @lampkin-diet