feat: Add verify presentation API and update StatusList APIs [DEV-2811] & [DEV-2669] #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaevMithran
force-pushed
the
presentation
branch
from
86312b2
to
fcf464f
Compare
Tweeddalex
changed the title
DaevMithran
force-pushed
the
presentation
branch
from
0413ca6
to
62c04a6
Compare
DaevMithran
changed the title
Tweeddalex
changed the title
Tweeddalex
changed the title
ankurdotb
requested changes
Jun 26, 2023
There was a problem hiding this comment.
- Branch is not up-to-date with develop and has merge conflicts. (Note: this will always result in an instant rejection.)
- Can we please work through the Swagger file and agree on inputs/outputs? So for example I can see credential status and resource create both use a text input for DIDs and then the rest is just a body. Before we do this in code, can we agree on the changes in Swagger first and simplify? For example, for credential status create, I expect to see:
- Issuer DID (text)
- Status List Name (text)
- Status Purpose (dropdown)
- Encrypted (dropdown)
- Options (optional, additional JSON for optional parameters)
...and so on for the other APIs. I at least want these for the credential service APIs, but would be good to do them for all and make it consistent as an approach.
@Tweeddalex Maybe for the scope of this, we do the simplifications for just presentation and credential status APIs, and then for next sprint do the implications and refactor for other APIs in a separate task.
DaevMithran
force-pushed
the
presentation
branch
from
c1e7e3e
to
623f8ad
Compare
ankurdotb
requested changes
Jul 6, 2023
cheqd-bot bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
## [2.4.0-develop.7](2.4.0-develop.6...2.4.0-develop.7) (2023-07-07) ### Features * Add verify presentation API and update StatusList APIs [DEV-2811] & [DEV-2669] ([#265](#265)) ([4e43430](4e43430))
|
🎉 This PR is included in version 2.4.0-develop.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
cheqd-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
## [2.5.0-develop.1](2.4.1...2.5.0-develop.1) (2023-07-11) ### Features * Add credential-status check API [DEV-2940] ([#293](#293)) ([34ad827](34ad827)) * Add Default role assigning while creating and account or signing in [DEV-2905] ([#286](#286)) ([c99bed2](c99bed2)) * Add verify presentation API and update StatusList APIs [DEV-2811] & [DEV-2669] ([#265](#265)) ([4e43430](4e43430)) ### Bug Fixes * Add policies to Verification API [DEV-2951] ([#294](#294)) ([d3c6ea9](d3c6ea9)) * Fix issue with broken webhook being used for setting default user role in LogTo [DEV-2962] ([#295](#295)) ([a3c8fde](a3c8fde))
|
🎉 This PR is included in version 2.5.0-develop.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
cheqd-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
## [2.5.0](2.4.1...2.5.0) (2023-07-11) ### Features * Add credential-status check API [DEV-2940] ([#293](#293)) ([34ad827](34ad827)) * Add Default role assigning while creating and account or signing in [DEV-2905] ([#286](#286)) ([c99bed2](c99bed2)) * Add verify presentation API and update StatusList APIs [DEV-2811] & [DEV-2669] ([#265](#265)) ([4e43430](4e43430)) ### Bug Fixes * Add policies to Verification API [DEV-2951] ([#294](#294)) ([d3c6ea9](d3c6ea9)) * Fix issue with broken webhook being used for setting default user role in LogTo [DEV-2962] ([#295](#295)) ([a3c8fde](a3c8fde))
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following
/presentation/verifyapi/credential-status/createapi/credential-status/updateapiapplication/x-www-form-urlencoded