fix: Fix error handling on tracking operations [DEV-3527] #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: DEV-3494 Make response bodies in predictable format |
lampkin-diet
reviewed
Jan 9, 2024
DaevMithran
changed the title
lampkin-diet
suggested changes
Jan 11, 2024
lampkin-diet
approved these changes
Jan 11, 2024
cheqd-bot bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
## [2.15.1-develop.1](2.15.0...2.15.1-develop.1) (2024-01-11) ### Bug Fixes * Fix error handling on tracking operations [DEV-3527] ([#461](#461)) ([53d7dfd](53d7dfd))
|
🎉 This PR is included in version 2.15.1-develop.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
lampkin-diet
pushed a commit
that referenced
this pull request
Jan 11, 2024
* fix: Fix error handling on tracking operations [DEV-3527] (#461) * fix: Fix error handling on tracking operations * Silently log tracking errors * Remove duplicate return statements --------- Co-authored-by: Andrew Nikitin <andrew.nikitin@cheqd.io> * chore(release): 2.15.1-develop.1 [skip ci] ## [2.15.1-develop.1](2.15.0...2.15.1-develop.1) (2024-01-11) ### Bug Fixes * Fix error handling on tracking operations [DEV-3527] ([#461](#461)) ([53d7dfd](53d7dfd)) * Simplyfing setting up user or customer from fetcher * Fix it for account creating --------- Co-authored-by: DaevMithran <61043607+DaevMithran@users.noreply.github.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
DaevMithran
added a commit
that referenced
this pull request
Jan 12, 2024
* feat: Add account create api * feat: Support m2m token in auth * feat: Add getAppScopes in auth * Update account/create api * Update create api flow & auth * Add request validator * Delegate tokens only to testnet account * chore: Suggestion to simplifying the user or customer getting (#469) * fix: Fix error handling on tracking operations [DEV-3527] (#461) * fix: Fix error handling on tracking operations * Silently log tracking errors * Remove duplicate return statements --------- Co-authored-by: Andrew Nikitin <andrew.nikitin@cheqd.io> * chore(release): 2.15.1-develop.1 [skip ci] ## [2.15.1-develop.1](2.15.0...2.15.1-develop.1) (2024-01-11) ### Bug Fixes * Fix error handling on tracking operations [DEV-3527] ([#461](#461)) ([53d7dfd](53d7dfd)) * Simplyfing setting up user or customer from fetcher * Fix it for account creating --------- Co-authored-by: DaevMithran <61043607+DaevMithran@users.noreply.github.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> --------- Co-authored-by: Andrew Nikitin <andrew.nikitin@cheqd.io> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
cheqd-bot bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
## [2.16.0](2.15.0...2.16.0) (2024-01-18) ### Features * Add M2MTokenUserInfoFetcher [DEV-3516] ([#468](#468)) ([279ec36](279ec36)), closes [#469](#469) [#461](#461) ### Bug Fixes * Fix error handling on tracking operations [DEV-3527] ([#461](#461)) ([53d7dfd](53d7dfd)) * Fix for update did [DEV-3494] ([#472](#472)) ([8a7682e](8a7682e)) * Make all the response bodies in predictable format [DEV-3494] ([#454](#454)) ([b3549d8](b3549d8)) * Update email to username in account/create ([#470](#470)) ([b19a353](b19a353))
|
🎉 This PR is included in version 2.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The earlier approach used to throw an INTERNAL ERROR if a tracking operations fails even if the api request was successfull.
The errors are just logged silently for now.