Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to REM, add css var for font-size & colors #69

Merged
merged 5 commits into from
Jul 5, 2022

Conversation

pierregradelet
Copy link
Contributor

Less changes

  • Rename .R to .propertyViewport
  • Remove less vars for background & colors and set it to css var
  • Add .propertyRem mixin to use rem & include media query in one go
  • Extract args in .propertyViewport to allow use of args like 10 10 10 or 10 auto 20 in margin / padding properties

@willybrauner
Copy link
Member

@pierregradelet I have updated variables folder and files struct


src/atoms
- src/atoms/variables-css.less
- src/atoms/variables-less.less

@pierregradelet pierregradelet merged commit 42cf008 into main Jul 5, 2022
@willybrauner willybrauner deleted the switch-to-rem branch October 4, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants