[#691] Fail attempt to fix pynose test discover on Windows #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #703 +/- ##
=======================================
Coverage 79.02% 79.03%
=======================================
Files 48 48
Lines 7811 7814 +3
Branches 1163 1163
=======================================
+ Hits 6173 6176 +3
Misses 1363 1363
Partials 275 275 see 1 file with indirect coverage changes
|
adiroiban
changed the title
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Fixes #691
The temp folder on macOS is not cleaned with Python 3.12
Changes
Allow cleanFolder in temp dir
How to try and test the changes
reviewers: @dumol
More of a fyi