Remove compute_dataset_item_512() #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Ethash spec defines the full dataset (DAG) in terms of 512-bit items. However, the items are always used in pairs. The implementation always uses calculate_dataset_item_1024() and calculate_dataset_item_512() was only used in tests.
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 98.64% 98.63% -0.01%
==========================================
Files 17 17
Lines 1332 1323 -9
==========================================
- Hits 1314 1305 -9
Misses 18 18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ethash spec defines the full dataset (DAG) in terms of 512-bit
items. However, the items are always used in pairs. The implementation
always uses calculate_dataset_item_1024() and
calculate_dataset_item_512() was only used in tests.