pull code #8
Merged
pull code #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In nnictl, we support debug mode from config file and --debug. If users does not set debug: true in config, nnictl will use --debug value.
… an valid json file (#899)
Wrong spell in INFO log.
* fix remote bug * add document * add document * update * update * update * update * fix remote issue * fix forEach * update doc according to comments * update * update * update * remove 'any more' * init * add overview * add picture * add trialkeeper.jpb * first version * update * add reference in Reference.rst * update doc according to comments * update doc according to comments * fix comments
There is one kind of version string like 'v0.5.2-gews11f', it is generated by installing from source code. In current trialKeeper, use exact version match, and this version string will cause code break in msranni/nni image, because our offical image use clean number version. Change the logic to fuzzy match, only match the main number of nni.
If user set remoteloggingType in config file, log content will not be transmitted from trialkeeper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.