-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/helix: new package (23.05) #261
Conversation
|
||
|
||
def do_install(self): | ||
self.cargo.install(wrksrc="helix-term") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If alice's change in #259 is merged this can be tweaked to use cargo_build_path
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't know this was even possible, i guess this also technically works for the original issue. not sure which is better :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's just get this in as is for now
I've converted this to a draft PR. I'm running into crashes (on x86_64) with the binary I built. Sometimes it panics with a Rust index out of bounds error, other times it just segfaults but it does so reliably as soon as I append line below ( |
i use the master branch of helix that i build myself and don't get any crashes. it could be:
can you reproduce the same failure just running |
Thanks for the suggestions @nekopsykose. I was able to reproduce the issue with a |
nice :D |
@q66 anything needed from me to get this one over the line? |
no, i just didn't get to it, sorry; it generally looks good, so i'll merge it as is |
Helix looks for system runtime files alongside the binary. Runtime files include themes and 'queries' for syntax highlighting but also a bunch of dynamic libraries for treesitter parsers. For this reason I've installed everything into
/usr/libexec/helix
with/usr/bin/hx
as a symlink to/usr/libexec/helix/hx
. However, if there's a better option happy to move things around.There a couple of patches for treesitter parsers that don't build with clang. I opened PR upstream as well.