Prevent long words from overflowing #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,6 +67,7 @@ | |||
| font-family: $hintFontFamily; | |||
| line-height: $hintFontSize; // Vertical centering. | |||
| white-space: nowrap; // Prevent breaking to new line. | |||
| word-wrap: break-word; // Ensure long words do not overflow. | |||
There was a problem hiding this comment.
I suppose you are using one of the width limiting classes in your screenshot? In that case, word-wrap property should only be applied for those 3 classes because otherwise it won't make any sense as words won't break at all.
There was a problem hiding this comment.
Ah yes, we are using hint--medium. I will update the PR.
| @@ -18,6 +18,7 @@ | |||
| &:after { | |||
| white-space: normal; | |||
| line-height: 1.4em; | |||
| word-wrap: break-word; // Ensure long words do not overflow. | |||
There was a problem hiding this comment.
@chinchang applied to correct file.
There was a problem hiding this comment.
Awesome! I'll get this ready for release. Thanks for the patch.
|
this is live in 2.3.2. Thanks @shadowhand 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this issue with user-generated text that overflowed the tooltip.
Before:
After: