-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Swagger version link to include latest release link and latest tag #231
base: dev
Are you sure you want to change the base?
Conversation
@cherylli, @JoshuaHinman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took me a few minutes to figure out what uri to use for LATEST_RELEASE
, but I got it working and it displays the version and link in swagger
I'm not sure what is request for the user story too. If its the LATEST_RELEASE of the dashboard API, then where do I find it on the git repo? Why couldn't it be added to the |
I also think it would be a better idea to keep track and pull the version from package.json if possible. We have 4 environments now it would be a pain to have to update all of them for each release this could be useful https://betterstack.com/community/questions/how-to-read-package-version-in-nodejs-code/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works with a direct link to the latest github release. But in the future, we may want to automate it.
@andram11 could you please resolve merge conflicts when you have a chance? Thanks! |
Updated the conflict and merged dev into local branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly if I update the version in package.json
Is there an automated way to only show (latest dev)
on the dev deployment (not the "stable" deployment)?
Otherwise, we could just leave it as it is now, have "latest dev" there, and hardcode to remove it on the stable version (I don't expect to update the stable version very often, at most every 2-3 months)
Prod won't have access to swagger, so it doesn't matter
Description
Not sure this is what was requested by the story but:
Issue link
Fixes # (https://app.clickup.com/t/86b32rm4d)
Type of change
How Has This Been Tested?
Manually by checking the docs endpoint
Checklist: