Skip to content

Commit

Permalink
test-matrix: Fix failure with artifact redirects.
Browse files Browse the repository at this point in the history
GitHub's API is now redirecting requests to download GHA artifacts
to https://productionresultssa0.blob.core.windows.net/. This service
rejects requests that contain an Authorization header, breaking our
publish-website.yml workflow. octocrab should not be sending this header
when redirected, and I have filed
XAMPPRocky/octocrab#562 to address the bug.

Until that PR is merged, we can work around this issue by enabling
octocrab's "follow-redirect" feature, which configures the tower
middleware to handle the redirect instead of octocrab, which (correctly)
doesn't include the authentication header in the redirected requests.
  • Loading branch information
korran committed Feb 6, 2024
1 parent ec2617a commit dafe2a8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ci-tools/test-matrix/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ edition = "2021"
[dependencies]
bytes = "1.5.0"
nextest-metadata = "0.9"
octocrab = { version = "0.32.0", default-features = false, features = ["rustls"] }
octocrab = { version = "0.32.0", default-features = false, features = ["rustls", "follow-redirect"] }
serde = "1.0.193"
serde-xml-rs = "0.6.0"
tinytemplate = { version = "1.1" }
tokio = { version = "1.34.0", default-features = false, features = ["macros", "rt"] }
zip = { version = "0.6.6", default-features = false, features = ["deflate"] }
zip = { version = "0.6.6", default-features = false, features = ["deflate"] }

0 comments on commit dafe2a8

Please sign in to comment.