Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the stash measurement functionality to AuthorizeAndStashCmd #1763

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Adding the stash measurement functionality to AuthorizeAndStashCmd #1763

merged 3 commits into from
Nov 4, 2024

Conversation

mhatrevi
Copy link
Collaborator

@mhatrevi mhatrevi commented Nov 1, 2024

No description provided.

@mhatrevi mhatrevi linked an issue Nov 1, 2024 that may be closed by this pull request
Add stashing functionality to Manifest based Authorization feature. #1660
Closed
swenson
swenson previously approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jhand2
jhand2 requested changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@jhand2 jhand2 left a comment •
edited by mhatrevi
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as #1752. Can we chery-pick that commit instead of creating a new one?

Yes, I mentioned that in the Slack message. This is "cherry-picked". The other PR is abandoned.

runtime/src/authorize_and_stash.rs Outdated Show resolved Hide resolved
@mhatrevi mhatrevi mentioned this pull request Nov 2, 2024
Closed
@mhatrevi mhatrevi enabled auto-merge (squash) November 2, 2024 00:24
@mhatrevi mhatrevi merged commit 9803094 into main Nov 4, 2024
11 checks passed
mhatrevi added a commit that referenced this pull request Nov 18, 2024
@mhatrevi
Adding the stash measurement functionality to AuthorizeAndStashCmd (#…
60d4893 
…1763)

(cherry picked from commit 9803094)
mhatrevi added a commit that referenced this pull request Nov 19, 2024
@mhatrevi
Adding the stash measurement functionality to AuthorizeAndStashCmd (#…
ba8e9e3 
…1763)

(cherry picked from commit 9803094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhand2 jhand2 jhand2 approved these changes

@swenson swenson swenson left review comments

@fdamato fdamato Awaiting requested review from fdamato fdamato is a code owner

@rusty1968 rusty1968 Awaiting requested review from rusty1968 rusty1968 is a code owner

@bluegate010 bluegate010 Awaiting requested review from bluegate010 bluegate010 is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

Assignees
No one assigned
Labels
Caliptra v1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add stashing functionality to Manifest based Authorization feature.
3 participants
@mhatrevi @swenson @jhand2