Extract mailbox API logic from caliptra_common into new caliptra-api crate. #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korran
force-pushed
the
caliptra-common
branch
from
e23f59f to
f4821b8
Compare
korran
changed the title
korran
force-pushed
the
caliptra-common
branch
from
f4821b8 to
02530a0
Compare
mhatrevi
previously approved these changes
Oct 23, 2023
Host libraries should not have transitive deps on caliptra-drivers.
korran
force-pushed
the
caliptra-common
branch
from
02530a0 to
7279e28
Compare
mhatrevi
approved these changes
Oct 24, 2023
jhand2
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this, have caliptra-hw-model depend on caliptra-api instead of caliptra_common. Host libraries should not have transitive deps on caliptra-drivers.