Make truthtable being able to accept unknown input width. #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
reviewed
Feb 2, 2022
src/main/scala/chisel3/util/experimental/decode/TruthTable.scala
Outdated
Show resolved
Hide resolved
jackkoenig
reviewed
Feb 2, 2022
src/main/scala/chisel3/util/experimental/decode/TruthTable.scala
Outdated
Show resolved
Hide resolved
sequencer
force-pushed
the
truthtable_infer_input_width
branch
2 times, most recently
from
7444a56 to
57428c9
Compare
Co-authored-by: Jack Koenig <koenig@sifive.com>
sequencer
force-pushed
the
truthtable_infer_input_width
branch
from
57428c9 to
75fd45b
Compare
jackkoenig
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2022
Widths are now padded to the maximum width of the inputs. Co-authored-by: Jack Koenig <koenig@sifive.com> (cherry picked from commit 546b4e1)
14 tasks
jackkoenig
added a commit
that referenced
this pull request
Feb 28, 2023
…#2387) An application like barstools may contain a main that loads an annotations file containing annotation classes that are not on it's classpath. This change allows unknown annotations to be preserved by wrapping them in a UnrecognizedAnnotation. If annotations are then output to a file, they will be unwrapped during serialization This feature can be enabled via an AllowUnrecognizedAnnotations annotation Co-authored-by: chick <chick.markley@sifive.com> Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the migration to RC.
I encountered this issue: sometime input or output width are unknown.
I originally think the input to decoder was a set of MicroOp, which is certainly a known width. in RC CSR, it shows the usage as an address decoder. I think it's reasonable to have an input unknown width.
However in the output side, the result of decode logic is always a control logic, padding it is an anti-pattern design.
So, this PR makes TruthTable accepting an unknown width to fit to the use cases like RC CSR.
Contributor Checklist
docs/src?Type of Improvement
API Impact
TruthTable will accept unknown width input now.
Backend Code Generation Impact
None
Desired Merge Strategy
Release Notes
TruthTable will accept unknown width input now.
Reviewer Checklist (only modified by reviewer)
3.4.x, [small] API extension:3.5.x, API modification or big change:3.6.0)?Please Merge?