Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new workflow to fixup backports for release notes #3252

Merged
merged 1 commit into from
May 5, 2023

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented May 5, 2023

The Mergify-generated backports do not currently include the information needed by the release notes generation automation. This new workflow will copy such information over to backport PRs.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash

Release Notes

Improve backport automation so that release notes generation from backport PRs works properly.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Internal Internal change, does not affect users, will be included in release notes label May 5, 2023
@jackkoenig
Copy link
Contributor Author

It works 🙂

The Mergify-generated backports do not currently include the information
needed by the release notes generation automation. This new workflow
will copy such information over to backport PRs.
@jackkoenig jackkoenig marked this pull request as ready for review May 5, 2023 21:19
@jackkoenig jackkoenig added this to the 3.6.x milestone May 5, 2023
@jackkoenig jackkoenig merged commit 86ccd1b into main May 5, 2023
@jackkoenig jackkoenig deleted the backport-fixup branch May 5, 2023 21:22
@mergify mergify bot added the Backported This PR has been backported label May 5, 2023
mergify bot pushed a commit that referenced this pull request May 5, 2023
The Mergify-generated backports do not currently include the information
needed by the release notes generation automation. This new workflow
will copy such information over to backport PRs.

(cherry picked from commit 86ccd1b)
mergify bot pushed a commit that referenced this pull request May 5, 2023
The Mergify-generated backports do not currently include the information
needed by the release notes generation automation. This new workflow
will copy such information over to backport PRs.

(cherry picked from commit 86ccd1b)
@jackkoenig
Copy link
Contributor Author

See how the backport PRs created from this PR are labeled and had the body of the PR message copied over.

@jackkoenig
Copy link
Contributor Author

Although it doesn't work for labels with spaces in them 😑, Will fix

mergify bot added a commit that referenced this pull request May 5, 2023
#3254)

* Add new workflow to fixup backports for release notes (#3252)

The Mergify-generated backports do not currently include the information
needed by the release notes generation automation. This new workflow
will copy such information over to backport PRs.

(cherry picked from commit 86ccd1b)

* Fix backport-fixup for labels with spaces (#3255)

(cherry picked from commit 8f7e7e6)

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot added a commit that referenced this pull request May 5, 2023
#3253)

* Add new workflow to fixup backports for release notes (#3252)

The Mergify-generated backports do not currently include the information
needed by the release notes generation automation. This new workflow
will copy such information over to backport PRs.

(cherry picked from commit 86ccd1b)

* Fix backport-fixup for labels with spaces (#3255)

(cherry picked from commit 8f7e7e6)

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
@sequencer sequencer mentioned this pull request Jun 20, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Internal Internal change, does not affect users, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants