Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report Builder errors even when exception is thrown #3341

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Jun 8, 2023

Fixes #1089

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Chisel will report multiple errors, but this can be cut short by any thrown Exception which would then take precedence over the previously encountered errors. Now Chisel will prioritize reporting errors even if an Exception is thrown.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x or 3.6.x depending on impact, API modification or big change: 5.0.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Jun 8, 2023
@jackkoenig jackkoenig added this to the 3.6.x milestone Jun 8, 2023
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackkoenig jackkoenig enabled auto-merge (squash) June 8, 2023 21:59
@jackkoenig jackkoenig force-pushed the report-errors-even-when-exception-thrown branch from 05df8e7 to c020212 Compare June 8, 2023 22:23
@jackkoenig jackkoenig merged commit b83f369 into main Jun 8, 2023
@jackkoenig jackkoenig deleted the report-errors-even-when-exception-thrown branch June 8, 2023 22:53
@mergify mergify bot added the Backported This PR has been backported label Jun 8, 2023
mergify bot pushed a commit that referenced this pull request Jun 8, 2023
mergify bot pushed a commit that referenced this pull request Jun 8, 2023
mergify bot added a commit that referenced this pull request Jun 8, 2023
(cherry picked from commit b83f369)

Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot added a commit that referenced this pull request Jun 8, 2023
(cherry picked from commit b83f369)

Co-authored-by: Jack Koenig <koenig@sifive.com>
@sequencer sequencer mentioned this pull request Jun 20, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhelpful error if you accidentally try to bitselect low to high
3 participants